Fix GitHub Actions and add comprehensive unit tests#3736
Open
Fix GitHub Actions and add comprehensive unit tests#3736
Conversation
- Update actions/setup-node to @v4 (was deprecated @v1.4.4) - Add comprehensive Jest test suite for updator script - Test version handling, package.json updates, CI workflow modifications - Mock all external dependencies and file operations - Cover error scenarios and input validation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Replace Jest with Mocha + Sinon for better compatibility - All 13 tests passing covering full automation functionality - Test version handling, package updates, CI modifications, error scenarios
… tests - Extract and export testable functions from updator.js - Add graceful gh-helpers import with fallback mock - Create comprehensive unit tests that import and test actual implementation - Include tests for sanitizeVersion, updateVersionFile, updateReadmeFile, updateCIFile, updatePackageJson, generateBranchName, createPRBody functions - Add integration tests for full workflow validation - Set up proper test infrastructure with Mocha + Sinon - Add .nyc_output to .gitignore to exclude test coverage cache 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Too complex, not convinced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions Fix + Unit Tests
Test Coverage
Critical Fix
The deprecated actions/setup-node@v1.4.4 was causing workflow warnings and potential future failures. Updated to @v4 for reliability.
Benefits