Implement optional direction vector to activateItem#3695
Open
Sheepy3 wants to merge 12 commits intoPrismarineJS:masterfrom
Open
Implement optional direction vector to activateItem#3695Sheepy3 wants to merge 12 commits intoPrismarineJS:masterfrom
Sheepy3 wants to merge 12 commits intoPrismarineJS:masterfrom
Conversation
Omena0
suggested changes
Aug 7, 2025
Contributor
Omena0
left a comment
There was a problem hiding this comment.
Please fix the linting errors. Otherwise this looks great, I've been looking forward to this feature for a while so i can automatically mend the bot's armor when durability is low.
Contributor
|
Tests don't seem to pass, might be unrelated as I don't see how this PR changes could cause this. Error seems to be: |
Omena0
approved these changes
Aug 7, 2025
This reverts commit 4cee5d1.
Member
|
Can you update the type def? |
Author
|
forgive me @extremeheat, but what do you mean? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements optional vector parameter into activateItem, as per issue #3621. allows for providing direction vector when bot is performing actions like throwing potions.