Conversation
|
Thanks for the PR! I think some of these might have been fixed in @grigoriy-chirkov's other PR but it would be good to integrate them with a smaller PR. That said, I noticed your changes to noc_axi4_bridge_write no longer consider the Also could you let us know your academic/industrial/other affiliation? |
|
If you look at the if block staring at line 202 in noc_axi4_bridge_write, Yes, I'm from Virginia Tech CS. |
|
Can you please explain why you do shifts in the other direction and how you calculate offset for non-cacheable writes? |
|
The 512-bit AXI data is created by gathering NOC packets toward MSB (noc_axi4_bridge_deser:181), therefore it needs to be shifted downward instead. The new strb now labels valid data received correctly. |
|
Ok I think this probably needs to be tested on the sparc core and/or with the other write sizes. I'd like for us to be more robust here but we need to make sure that it's not breaking other existing configurations at the same time. |
This PR fixes two issues in the noc-axi4 bridge: