Issue 1580 - Implementing ChunkedFaceIterator & assembly::face_types#1614
Merged
Rohit-Kakodkar merged 11 commits intodevelfrom Feb 5, 2026
Merged
Issue 1580 - Implementing ChunkedFaceIterator & assembly::face_types#1614Rohit-Kakodkar merged 11 commits intodevelfrom
Rohit-Kakodkar merged 11 commits intodevelfrom
Conversation
6 tasks
Collaborator
Rohit-Kakodkar
left a comment
Rohit-Kakodkar
left a comment
There was a problem hiding this comment.
Looks good. Minor changes.
| * local face point indices | ||
| */ | ||
| KOKKOS_INLINE_FUNCTION | ||
| void get_face_coordinates(const specfem::mesh_entity::dim3::type face_type, |
Collaborator
There was a problem hiding this comment.
This function got refactored into mesh_entities or connections. Can you use that.
Collaborator
There was a problem hiding this comment.
Seems like this was missed
| * local edge point index | ||
| */ | ||
| KOKKOS_INLINE_FUNCTION | ||
| void get_edge_coordinates(const specfem::mesh_entity::dim2::type edge_type, |
Collaborator
There was a problem hiding this comment.
This function is also refactored
Collaborator
Author
There was a problem hiding this comment.
Ok, weird, it was definitely remove in "address comments" commit. I think some thing weird happened, when I did the merge conflicts on github. Will reset.
Collaborator
Author
There was a problem hiding this comment.
Nope, there were two!
icui
approved these changes
Feb 2, 2026
Co-authored-by: Rohit-Kakodkar <[email protected]>
Rohit-Kakodkar
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the ability to iterate over faces, so that coupling may be
implemented.
Commits
Issue Number
Closes #1580
Checklist
Please make sure to check developer documentation on specfem docs.