Skip to content

1554 - Move medium to core Part II: refactor medium_container#1612

Merged
icui merged 14 commits intodevelfrom
1554-medium2
Feb 2, 2026
Merged

1554 - Move medium to core Part II: refactor medium_container#1612
icui merged 14 commits intodevelfrom
1554-medium2

Conversation

@icui
Copy link
Collaborator

@icui icui commented Jan 27, 2026

Description

Inheritance structure:

For point (mostly same as current):

  • medium_container::point_properties defines medium-specfic fields like kappa, rho etc. (previously point::impl::properties)
  • point::properties inherits medium_container::point_properties with added tags

For domain (refactored to be consistent with point)

  • medium_container::domain_properties defines medium-specfic fields like kappa, rho etc. (previously medium::properites::data_container)
  • medium::impl::accessor is moved to assembly::impl::domain_accessor
  • assembly::impl::domain_properties inherit assembly::impl::domain_accessor and medium_container::domain_properties (previously medium::properties_container)

Issue Number

Adds to #1554

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui icui closed this Jan 28, 2026
@icui icui reopened this Jan 28, 2026
Base automatically changed from 1554-medium to 1554-dk January 29, 2026 13:45
@icui icui requested review from Rohit-Kakodkar and lsawade and removed request for Rohit-Kakodkar January 30, 2026 05:55
@icui icui marked this pull request as ready for review January 30, 2026 05:55
@icui icui requested a review from Rohit-Kakodkar January 30, 2026 06:07
KOKKOS_FUNCTION specfem::point::mass_inverse<
DimensionTag, specfem::element::medium_tag::acoustic, UseSIMD>
specfem::medium::impl_mass_matrix_component(
specfem::medium_physics::impl_mass_matrix_component(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these function now be in specfem::medium_physics::impl so that
specfem::medium_physics::impl::mass_matrix_component?

Not that it matters, but I feel like if we have impl namespaces we truly would havea a natural flow (thinking also about your assembly::impl changes)

Base automatically changed from 1554-dk to devel February 1, 2026 21:10
@icui icui merged commit fc0558a into devel Feb 2, 2026
8 checks passed
@icui icui deleted the 1554-medium2 branch February 2, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants