1554 - Move medium to core Part II: refactor medium_container#1612
Merged
1554 - Move medium to core Part II: refactor medium_container#1612
Conversation
lsawade
approved these changes
Jan 30, 2026
| KOKKOS_FUNCTION specfem::point::mass_inverse< | ||
| DimensionTag, specfem::element::medium_tag::acoustic, UseSIMD> | ||
| specfem::medium::impl_mass_matrix_component( | ||
| specfem::medium_physics::impl_mass_matrix_component( |
Collaborator
There was a problem hiding this comment.
should these function now be in specfem::medium_physics::impl so that
specfem::medium_physics::impl::mass_matrix_component?
Not that it matters, but I feel like if we have impl namespaces we truly would havea a natural flow (thinking also about your assembly::impl changes)
Rohit-Kakodkar
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inheritance structure:
For point (mostly same as current):
medium_container::point_propertiesdefines medium-specfic fields likekappa,rhoetc. (previouslypoint::impl::properties)point::propertiesinheritsmedium_container::point_propertieswith added tagsFor domain (refactored to be consistent with point)
medium_container::domain_propertiesdefines medium-specfic fields likekappa,rhoetc. (previouslymedium::properites::data_container)medium::impl::accessoris moved toassembly::impl::domain_accessorassembly::impl::domain_propertiesinheritassembly::impl::domain_accessorandmedium_container::domain_properties(previouslymedium::properties_container)Issue Number
Adds to #1554
Checklist
Please make sure to check developer documentation on specfem docs.