port over ifeval#358
Merged
justusmattern27 merged 5 commits intoPrimeIntellect-ai:mainfrom Jun 4, 2025
Merged
Conversation
Contributor
|
amazing, thanks a lot! Let me run this and then we'll merge if results look good |
Contributor
Author
|
I also just reproduced my results from the testing dataset in the original PR 👍 (hacked in the existing completions from Mistral) |
Contributor
|
looks good imo! I also just ran some sanity checks 👍 @rasdani there are some styling errors right now - to fix them, you can run the following: Otherwise i can also create a PR for your branch - just lmk! |
Contributor
|
E2E tests are failing due to permissions but this can be ignored since your PR doesn't affect them |
Contributor
Author
|
pre-commit and linter pass for me locally. weird :/ could you fix, pls? @justusmattern27 |
Contributor
Author
|
linting fixed. should be good to merge now 👍 @justusmattern27 |
Contributor
|
perfect, works now! @rasdani Merging this - thanks a lot for your contribution 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port of PrimeIntellect-ai/genesys#80