Fix flash-attn-cute namespace conflict on arm64#1949
Fix flash-attn-cute namespace conflict on arm64#1949JannikSt merged 1 commit intofeature/arm64-supportfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| uv pip install flash-attn --no-build-isolation; \ | ||
| uv pip install flash-attn --no-build-isolation && \ | ||
| uv pip install --reinstall --no-deps \ | ||
| "flash-attn-cute @ git+https://github.com/Dao-AILab/flash-attention.git@main#subdirectory=flash_attn/cute"; \ |
There was a problem hiding this comment.
Unpinned reinstall breaks deterministic arm64 builds
Medium Severity
uv pip install --reinstall --no-deps "flash-attn-cute @ ...@main" bypasses uv.lock and pulls whatever commit main points to at build time. This makes Dockerfile.cuda non-deterministic and can introduce runtime incompatibilities with the pinned flash-attn/dependency set even when the lockfile is unchanged.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7938742c79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uv pip install flash-attn --no-build-isolation; \ | ||
| uv pip install flash-attn --no-build-isolation && \ | ||
| uv pip install --reinstall --no-deps \ | ||
| "flash-attn-cute @ git+https://github.com/Dao-AILab/flash-attention.git@main#subdirectory=flash_attn/cute"; \ |
There was a problem hiding this comment.
Reinstalling flash-attn-cute from git+...@main makes the arm64 image build non-reproducible and can silently pull incompatible upstream changes, even when uv.lock pins flash-attn-cute to a specific commit. In practice, rebuilding the same repo revision at a later date may produce a different FA4 kernel set (or fail entirely), which is especially risky for training/runtime stability on arm64.
Useful? React with 👍 / 👎.
1 participant
Reinstall flash-attn-cute after flash-attn on arm64. Installing flash-attn overwrites the flash_attn/cute/ directory with a stub, breaking the real FA4 kernels. This causes the trainer to fail validation at startup.
Note
Cursor Bugbot is generating a summary for commit 7938742. Configure here.