Skip to content

Conversation

@Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Oct 28, 2025

Questions Answers
Branch? dev
Description? Added endpoints for domain "ShowcaseCard"
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? ⬇️
Fixed issue or discussion? N/A
Related PRs N/A
Sponsor company lefevre.dev

Blocked by Core

Can't use the handler for PrestaShop\PrestaShop\Core\Domain\ShowcaseCard\Query\GetShowcaseCardIsClosed
=> Because it returns a boolean and not a Value Object
=> Thanks @jolelievre & @boherm :)
=> Fixed by PrestaShop/PrestaShop/pull/40563

How to test 🚧

  • Create an API Client with these scopes : showcase_card_read & showcase_card_write
  • Request an access token
  • Query 1 :
    • Method : GET
    • URI : /showcase-cards/monitoring_card/1
    • Response :
      • HTTP Code : 200
      • HTTP Body : Contains a JSON
         {"closed": false, "showcaseCardName": "monitoring_card", "employeeId" : 1 }
      • Check in BO for the page monitoring if the showcase card is visible
  • Query 2 :
    • Method : PUT
    • URI : /showcase-cards/monitoring_card/1/close
    • Body : Empty
    • Response :
      • HTTP Code : 201
      • HTTP Body : Contains a JSON
         {"closed": true, "showcaseCardName": "monitoring_card", "employeeId" : 1 }
      • Check in BO for the page monitoring if the showcase card is not visible
  • Query 3 :
    • Method : GET
    • URI : /showcase-cards/monitoring_card/1
    • Response :
      • HTTP Code : 200
      • HTTP Body : Contains a JSON
         {"closed": true, "showcaseCardName": "monitoring_card", "employeeId" : 1 }

@boherm
Copy link
Member

boherm commented Jan 20, 2026

Hi @Progi1984!

I made some fix on your PR.

With this Core PR PrestaShop/PrestaShop#40558, it's works well and permit to have CQRS query with scalar values!

@boherm boherm force-pushed the showcaseCard branch 2 times, most recently from ec9e31b to a561fc6 Compare January 21, 2026 08:53
@Progi1984 Progi1984 force-pushed the showcaseCard branch 5 times, most recently from 05921b9 to 5b3690b Compare January 26, 2026 13:20
@Progi1984 Progi1984 marked this pull request as ready for review January 27, 2026 09:24
@Progi1984
Copy link
Member Author

Ping for review :

@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Feb 3, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin API Contributions Waiting for QA Status: Waiting for QA feedback

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.

6 participants