-
Notifications
You must be signed in to change notification settings - Fork 25
Added endpoints for domain "ShowcaseCard" #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Progi1984
wants to merge
1
commit into
PrestaShop:dev
Choose a base branch
from
Progi1984:showcaseCard
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97e2b14 to
1e01dc5
Compare
b38d02a to
a319b89
Compare
Member
|
Hi @Progi1984! I made some fix on your PR. With this Core PR PrestaShop/PrestaShop#40558, it's works well and permit to have CQRS query with scalar values! |
ec9e31b to
a561fc6
Compare
05921b9 to
5b3690b
Compare
Member
Author
|
Ping for review :
|
5b3690b to
534bdac
Compare
boherm
approved these changes
Feb 3, 2026
nicosomb
approved these changes
Feb 3, 2026
Touxten
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by Core
Can't use the handler for
PrestaShop\PrestaShop\Core\Domain\ShowcaseCard\Query\GetShowcaseCardIsClosed=> Because it returns a boolean and not a Value Object
=> Thanks @jolelievre & @boherm :)
=> Fixed by PrestaShop/PrestaShop/pull/40563
How to test 🚧
showcase_card_read&showcase_card_writeGET/showcase-cards/monitoring_card/1{"closed": false, "showcaseCardName": "monitoring_card", "employeeId" : 1 }PUT/showcase-cards/monitoring_card/1/close{"closed": true, "showcaseCardName": "monitoring_card", "employeeId" : 1 }GET/showcase-cards/monitoring_card/1{"closed": true, "showcaseCardName": "monitoring_card", "employeeId" : 1 }