Preserve subprocesses after output stream errors - #22573
Draft
desertaxle wants to merge 1 commit into
Draft
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR keeps subprocesses running to completion when stdout or stderr forwarding fails, restoring compatibility with AnyIO 4.14.2.
Details
AnyIO 4.14.2 closes underlying subprocess pipe transports during cleanup. When Prefect's output consumer raises, that cleanup can terminate the flow process before it records a final state.
run_processnow drains both pipes without forwarding their output and waits for the process to exit before re-raising the original streaming error. Cancellation continues through the existing termination path because the fallback handles only ordinary exceptions.The regression emits one megabyte to each output stream after forcing a forwarding failure and verifies that the child still reaches completion. The focused process utility and runner tests pass with both AnyIO 4.14.1 and 4.14.2.