Fix/issue 20117 runner aenter race#21124
Open
jellyfish0316 wants to merge 3 commits intoPrefectHQ:mainfrom
Open
Fix/issue 20117 runner aenter race#21124jellyfish0316 wants to merge 3 commits intoPrefectHQ:mainfrom
jellyfish0316 wants to merge 3 commits intoPrefectHQ:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #20117
this PR prevents concurrent
Runnerauto-starts from racing on shared async lifecycle state.Summary
When multiple flow runs try to auto-start the same
Runnerconcurrently, they could race inRunner.__aenter__and attempt to enter or tear down shared async contexts more than once. In practice this could surface as:RuntimeError("Each CancelScope may only be used for a single 'with' block")RuntimeError("Attempted to exit cancel scope in a different task than it was entered in")Cannot open a client instance more than onceThis change serializes runner lifecycle transitions with a private lock, tracks active context users, and ensures final teardown is performed by the task that entered the shared async context stack.
It also adds a focused regression test covering concurrent implicit startup through
execute_bundle.Validation:
uv run pytest tests/runner/test_runner.py -k "test_concurrent_execute_bundle_initializes_runner_once" -vv