Experiment: defer heavy imports in logging handlers#20966
Draft
Experiment: defer heavy imports in logging handlers#20966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a focused experiment to reduce common CLI startup overhead by deferring heavy imports in
prefect.logging.handlersuntil they are actually needed.It intentionally does not change plugin initialization semantics or
prefect.contextbehavior.What changed
src/prefect/logging/handlers.pywith cached local loader helpers for:prefect.contextprefect.client.orchestration.get_clientprefect.client.schemas.actions.LogCreateprefect.settingsfrom_timestampandMissingContextErrorWhy
This is the narrowest low-risk candidate from recent CLI startup investigations. If it helps, we can keep it; if it does not, this still gives us concrete data for future import-graph work.
Local validation
uv run pytest tests/test_logging.py -quv run pytest tests/cli/test_version.py tests/cli/test_config.py -quv run ruff check src/prefect/logging/handlers.pyLocal bench note
Local
cli-benchresults were noisy and not consistently positive on my machine, so this is being sent to CI as an empirical check rather than a claimed win.