WeBWorK: only match image pattern on nonempty strings #2775
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in on pretext-support, if something is out of sorts with a webwork2 server, the static PTX rendering of an exercise might have
<image source=""/>with an empty source attribute. Normally when something is actually there, we capture what is there so we can download the webwork2 server's cached image file, and then we replace what is in@sourcewith an appropriate generated image file path. But if we've captured the empty string, bad things happen when we try to replace all instances of the empty string...So this change ensures the match only happens on nonempty source attributes.