SBS HTML layout fixes for varied items in figure #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2772
Root issue is that the CSS "bypasses" a figure in CSS so it can align the "figure" (i.e. image) parts in one row (content) and the figcaptions in another. Asymptote links, or other content dropped in as elements between the image and figcaption break that.
Solution is to make sure that images in sbs still get a
<div class="image-box"/>that contains anything that should be grouped inside the "content row".It could be that we end up needing a separate class
image-box-sbsor something to differentiate, but using the existingimage-boxappears to work for now and not introduce any unwanted styles within a SBS.FYI for @sean-fitzpatrick