dnsparser: Harden the DNS parser against malformed records#17077
Open
rgacogne wants to merge 7 commits intoPowerDNS:masterfrom
Open
dnsparser: Harden the DNS parser against malformed records#17077rgacogne wants to merge 7 commits intoPowerDNS:masterfrom
rgacogne wants to merge 7 commits intoPowerDNS:masterfrom
Conversation
There is no security issue: we are not reading outside of the packet or bypassing any checks. We might however accept packets that are not valid and that we could discard earlier in the process. Reported by nrabrenovic in YWH-PGM6095-137. Signed-off-by: Remi Gacogne <[email protected]>
Signed-off-by: Remi Gacogne <[email protected]>
Signed-off-by: Remi Gacogne <[email protected]>
Signed-off-by: Remi Gacogne <[email protected]>
… the process Signed-off-by: Remi Gacogne <[email protected]>
…tReader and RecordTextWriter This is needed to deal with a bug (PowerDNS#17000) in the authoritative code that at some point created non-empty ENT records in our databases. Signed-off-by: Remi Gacogne <[email protected]>
Pull Request Test Coverage Report for Build 23799818125Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Remi Gacogne <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
There is no security issue: we are not reading outside of the packet or bypassing any checks. We might however accept packets that are not valid and that we could discard earlier in the process.
Reported by
nrabrenovicakaSalvor Labs - https://salvor.frin YWH-PGM6095-137, many thanks to them!Checklist
I have: