fix: do not retry transactions on 40001 SQL error - #4222
Conversation
1afa5fb to
665f55c
Compare
|
Should we vendor hasql-notifications for now since there's no response for diogob/hasql-notifications#30 ? I remember we did this before too. It's a single file so no major maintenance problem there IMO. |
|
We should not vendor it, for two reasons:
|
ff133bf to
23426d2
Compare
Thanks for the ping suggestion (I should've done this weeks ago). Changes are now merged and released upstream!
OK, so this would be the only blocker for this PR for now then. Also some |
4fd5a69 to
592802c
Compare
505b11b to
32b8f4d
Compare
32b8f4d to
c82b65e
Compare
40001 SQL error
|
@laurenceisla Possible to backport? Would it be hard because it depends on a newer nixpkgs? |
Yes, I'm afraid it will result in a similar case as #4702 (comment), due to the dependencies. |
Should close #3673.
hasqlversion: Add support for hasql 1.9 diogob/hasql-notifications#30