Open
Conversation
andrewm4894
approved these changes
Mar 23, 2026
Contributor
|
Size Change: +1.19 kB (0%) Total Size: 110 MB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts LemonTable’s header loader rendering to prevent header/content layout shift during loading states (notably in Error Tracking issues list layouts), by ensuring the loader doesn’t introduce an extra header column.
Changes:
- Render the loader in its own
<thead>row instead of as an additional<th>in the main header row. - Compute a
colSpanintended to match the visible header column count. - Add header CSS to make the loader row take up no space while still allowing the loader bar to be positioned/visible.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/lib/lemon-ui/LemonTable/LemonTable.tsx | Moves loader into a dedicated header row and adds colSpan calculation to avoid column-count changes while loading. |
| frontend/src/lib/lemon-ui/LemonTable/LemonTable.scss | Styles the loader host header cell to have zero height/padding and no borders so it doesn’t affect layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Reviews (1): Last reviewed commit: "fix: copy" | Re-trigger Greptile |
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 9 snapshots (9 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Contributor
Storybook visual regression tests failedIf your changes intentionally update UI snapshots: add the If you didn't change any UI: this is likely a flaky snapshot — wait for a fix to land on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've discovered a nasty bug in ET issues list due to recent changes. In some layout configurations in
LemonTablecontent would shift and create this thing.Made it so that loader is another row instead of being another column.
All good now
