Skip to content

chore(replay): use INTERNAL_API_SECRET for rasterizer recording-api auth#52019

Open
TueHaulund wants to merge 1 commit intomasterfrom
chore/rasterizer-internal-api-secret
Open

chore(replay): use INTERNAL_API_SECRET for rasterizer recording-api auth#52019
TueHaulund wants to merge 1 commit intomasterfrom
chore/rasterizer-internal-api-secret

Conversation

@TueHaulund
Copy link
Contributor

Summary

  • Use INTERNAL_API_SECRET env var consistently for recording-api authentication in the rasterizer, matching the charts config (secret_env: INTERNAL_API_SECRET: INTERNAL_API_SECRET)
  • Removes the old RECORDING_API_SECRET reference — a single consistent name across all services

Test plan

@assign-reviewers-posthog assign-reviewers-posthog bot requested review from a team, fasyy612 and ksvat and removed request for a team March 23, 2026 22:09
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 23, 2026

Comments Outside Diff (1)

  1. bin/temporal-recording-rasterizer-worker, line 83 (link)

    P1 Stale env var name in local dev script

    config.ts now reads INTERNAL_API_SECRET, but this script still injects the variable under the old name RECORDING_API_SECRET. The container will receive the secret under a name it no longer looks for, so config.recordingApiSecret will always be an empty string in local development — breaking the rasterize-recording workflow for anyone running this script locally, for the same reason the charts deployment was broken before the charts PR fix.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: bin/temporal-recording-rasterizer-worker
    Line: 83
    
    Comment:
    **Stale env var name in local dev script**
    
    `config.ts` now reads `INTERNAL_API_SECRET`, but this script still injects the variable under the old name `RECORDING_API_SECRET`. The container will receive the secret under a name it no longer looks for, so `config.recordingApiSecret` will always be an empty string in local development — breaking the rasterize-recording workflow for anyone running this script locally, for the same reason the charts deployment was broken before the charts PR fix.
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: bin/temporal-recording-rasterizer-worker
Line: 83

Comment:
**Stale env var name in local dev script**

`config.ts` now reads `INTERNAL_API_SECRET`, but this script still injects the variable under the old name `RECORDING_API_SECRET`. The container will receive the secret under a name it no longer looks for, so `config.recordingApiSecret` will always be an empty string in local development — breaking the rasterize-recording workflow for anyone running this script locally, for the same reason the charts deployment was broken before the charts PR fix.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "chore(replay): use INTERNAL_API_SECRET f..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants