Remove unused exe.py PyInstaller entry point#855
Merged
PavelMakarchuk merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
exe.py was the entry point for a PyInstaller standalone binary build (via policyengine_taxsim.spec) that processes records one-at-a-time via the single-record Simulation path. It was never actively built (no CI workflow, no Makefile, no docs), and its per-record approach is strictly inferior to the Microsim batch path in cli.py. - Delete policyengine_taxsim/exe.py - Delete policyengine_taxsim/policyengine_taxsim.spec The export_household and generate_household helpers stay — they are re-exported from policyengine_taxsim/__init__.py and exercised directly by tests/test_state_output_adapters.py. Note: this removes the one code path that emitted verbose text output for idtl=5. If that's needed, port generate_text_description_output into the Microsim path in cli.py. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes `policyengine_taxsim/exe.py` and `policyengine_taxsim/policyengine_taxsim.spec`. These were the entry point and spec for a PyInstaller standalone-binary build that:
What stays
`export_household` and `generate_household` are unchanged — they're re-exported from `policyengine_taxsim/init.py` and exercised by `tests/test_state_output_adapters.py`.
Note on idtl=5 text output
`exe.py` was the only path that emitted verbose text output (Dan's server-style `Input Data... State Tax Calculation...` format) for `idtl=5`. The main `cli.py policyengine` command always writes CSV regardless of idtl. If text output is needed going forward, port `generate_text_description_output` into the Microsim path.
Test plan
🤖 Generated with Claude Code