Unify sctc to use pe-us state_ctc aggregate#853
Merged
PavelMakarchuk merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Remove the duplicated per-state `state_variables:` dict from `sctc:` in variable_mappings.yaml. The `sctc` field now routes through pe-us's `state_ctc` variable, which aggregates `gov.states.household.state_ctcs` — the same catalog CDCC/EITC already use via state_cdcc/state_eitc. - `taxsim_sctc` moves from `DIRECT_STATE_MAPPING_ADAPTERS` to `OUTPUT_ADAPTER_BASE_VARIABLES` with base `state_ctc`. - OK and MN component-split overrides stay in `OUTPUT_ADAPTER_OVERRIDES` (legitimate special cases). - Matches the pattern already used for v38/v39. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the duplicated per-state
state_variables:dict fromsctc:invariable_mappings.yaml. Thesctcoutput field now routes through pe-us'sstate_ctcvariable, which aggregatesgov.states.household.state_ctcs— the same catalog thatstate_cdcc/state_eitcalready use via thev38/v39adapters.Motivation
The
sctcmapping was the last holdout using the per-statestate_variables:lookup instead of the shared pe-us aggregate. That created:state_ctcs.yaml) and pe-taxsim (variable_mappings.yaml).CT: ct_child_tax_rebate, a one-time 2022 rebate, still producing phantom values for 2023+ (surfaced in policyengine-taxsim#849). The pe-us aggregate (once pe-us#8146 merges) won't have this problem.After this change,
sctcbehaves consistently withv38(CDCC) andv39(EITC): single source of truth in pe-us, component-split overrides in the resolver for OK and MN.Changes
state_output_resolver.py:taxsim_sctcmoves fromDIRECT_STATE_MAPPING_ADAPTERStoOUTPUT_ADAPTER_BASE_VARIABLESwith base variablestate_ctc.variable_mappings.yaml: removes the 20-statestate_variables:block undersctc:.adapter:ok_child_tax_credit_component,adapter:mn_child_tax_credit_component) stay inOUTPUT_ADAPTER_OVERRIDES["taxsim_sctc"]— unchanged behavior.Test plan
Related
ct_child_tax_rebatefromstate_ctcs.yaml🤖 Generated with Claude Code