fix(synthese-validation): fix geometry filter and revamp validation query building#3928
Merged
Pierre-Narcisi merged 12 commits intodevelopfrom Feb 13, 2026
Merged
fix(synthese-validation): fix geometry filter and revamp validation query building#3928Pierre-Narcisi merged 12 commits intodevelopfrom
Pierre-Narcisi merged 12 commits intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3928 +/- ##
===========================================
+ Coverage 86.28% 86.30% +0.01%
===========================================
Files 137 137
Lines 10795 10814 +19
===========================================
+ Hits 9315 9333 +18
- Misses 1480 1481 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ing multiple area filters (and its faster ! )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3918 -> check b6f6bdf
Instead of testing in(COM1 or COM2) and in(DEP1 or DEP2), we test if the obs is in (COM1,COM2,DEP1,DEP2)
We also improve validation query building by fixing it once and for all ! (I hope)
Regarding performance, on an instance with 1.7M observations