Skip to content

fix(synthese-validation): fix geometry filter and revamp validation query building#3928

Merged
Pierre-Narcisi merged 12 commits intodevelopfrom
fix/geomfilter
Feb 13, 2026
Merged

fix(synthese-validation): fix geometry filter and revamp validation query building#3928
Pierre-Narcisi merged 12 commits intodevelopfrom
fix/geomfilter

Conversation

@jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Feb 11, 2026

resolves #3918 -> check b6f6bdf

Instead of testing in(COM1 or COM2) and in(DEP1 or DEP2), we test if the obs is in (COM1,COM2,DEP1,DEP2)

We also improve validation query building by fixing it once and for all ! (I hope)

Regarding performance, on an instance with 1.7M observations

  • fetching 5000 obs to be validated : 2.16.4 -> ~10s; 2.17dev -> ~2s
  • with profile filters : 2.16.4 -> ~10s; 2.17dev -> ~10s (it does not work in 2.16.4...)
  • with profile filters and geometries : ~14s (2.17dev)

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.30%. Comparing base (5a28660) to head (37e4058).
⚠️ Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
...nature/core/gn_synthese/utils/query_select_sqla.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3928      +/-   ##
===========================================
+ Coverage    86.28%   86.30%   +0.01%     
===========================================
  Files          137      137              
  Lines        10795    10814      +19     
===========================================
+ Hits          9315     9333      +18     
- Misses        1480     1481       +1     
Flag Coverage Δ
pytest 86.30% <98.63%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camillemonchicourt camillemonchicourt changed the title fix(validation): fix geometry filter and revamp validation query building fix(synthese-validation): fix geometry filter and revamp validation query building Feb 13, 2026
@Pierre-Narcisi Pierre-Narcisi merged commit 02d8fd5 into develop Feb 13, 2026
10 checks passed
@Pierre-Narcisi Pierre-Narcisi deleted the fix/geomfilter branch February 13, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants