feat(platform): include remote file error details#21413
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
getFileStream()orgetFileStreamAndMetadata()receives a non-successful remote response, preserve the HTTP status and add a whitespace-normalized, size-bounded response body to the thrown error.This is a diagnostic improvement related to #21411. It does not claim to fix the intermittent File Stash / S3 400 itself. It makes service error codes such as
SignatureDoesNotMatch,InvalidToken, orNoSuchKeyvisible so the underlying failure can be distinguished.The platform package is bumped from
3.4.0to3.4.1, and generated output is rebuilt.Validation
corepack pnpm --filter @pipedream/platform run buildcorepack pnpm exec eslint platform/lib/file-stream.ts platform/__tests__/file-stream.jsgit diff --checkThe default Jest launch is currently blocked before test execution by the repository lock resolving Babel 8 with Jest 29 (
loadPartialConfignow requires a callback). Running the CommonJS suites with transforms disabled passed. The only full-suite failure under that workaround is the unchanged live-network Axios test timing out after five seconds.Checklist
Versioning
@pipedream/platformversion bumped from3.4.0to3.4.1New app
CodeRabbit review