Skip to content

Use a temporary build directory for Python module output #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjsowa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use a temporary build directory for Python module output #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions generate_parameter_library/cmake/generate_parameter_library.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,17 @@ function(generate_parameter_module LIB_NAME YAML_FILE)
# Set the yaml file parameter to be relative to the current source dir
set(YAML_FILE ${CMAKE_CURRENT_SOURCE_DIR}/${YAML_FILE})

set(LIB_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/include/${PROJECT_NAME})
file(MAKE_DIRECTORY ${LIB_INCLUDE_DIR})
# Create a build-local output directory for the generated Python module
set(PY_BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR}/generate_parameter_module_temp)
file(MAKE_DIRECTORY ${PY_BUILD_DIR})

find_package(ament_cmake_python)
ament_get_python_install_dir(python_install_dir)
set(PARAM_HEADER_FILE ${CMAKE_INSTALL_PREFIX}/${python_install_dir}/${PROJECT_NAME}/${LIB_NAME}.py)

# Generate the module for the python
# Generate into the build tree, not into CMAKE_INSTALL_PREFIX
set(PARAM_HEADER_FILE ${PY_BUILD_DIR}/${LIB_NAME}.py)

# Generate the module for Python
add_custom_command(
OUTPUT ${PARAM_HEADER_FILE}
COMMAND ${generate_parameter_library_python_BIN} ${PARAM_HEADER_FILE} ${YAML_FILE} ${VALIDATE_HEADER_FILENAME}
Expand All @@ -141,6 +144,8 @@ function(generate_parameter_module LIB_NAME YAML_FILE)
$<INSTALL_INTERFACE:include>
)

# Install the generated module into the Python site-packages dir
install(FILES ${PARAM_HEADER_FILE} DESTINATION ${CMAKE_INSTALL_PREFIX}/${python_install_dir}/${PROJECT_NAME})
endfunction()

# create custom test function to pass yaml file into test main
Expand Down
Loading