Use a temporary build directory for Python module output#303
Conversation
|
If the current setup fails on the buildfarm, why haven't that failed earlier? Or is it that simple, nobody released a python node using this library? |
From what I see, we are the first 😎 |
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
The result looks good, just not sure if there is a more cmake-native way in fixing this. So, waiting for another review.
btw: I remembered that we had an issue about python install location, but it was in setup.py configs #206.
|
@christophfroehlich Any chance this gets merged and released soon? I'm getting a lot of spam from ROS buildfarm about failing jobs... |
sea-bass
left a comment
sea-bass
left a comment
There was a problem hiding this comment.
This looks good at a glance!
My only question (from limited experience working in this package): how does this change affect symlink-install and/or merge-install workflows, if at all? Maybe worth a quick test
In symlink-install, the generator python module in install directory will be symlinked to the one created in the temp build directory. The merge-install is not affected at all. |
|
I've tested the three options now with generate_parameter_module_example, I don't see any downsides. |
christophfroehlich
merged commit 72887f5
into
PickNikRobotics:main
|
@bjsowa Now our example_module fails on the buildfarm Any idea how to fix this? |
It doesn't seem related as |
* Use a temporary build directory for Python module output (PickNikRobotics#303) * Added missing gmock/gtest dependency (PickNikRobotics#304) --------- Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]> * make scripts accessible to find_program cmake function. --------- Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Błażej Sowa <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]> Co-authored-by: Alexandre Arnoux <[email protected]> Co-authored-by: alexandre-arnoux-dx <[email protected]>
|
Oh my bad, I have tested the options with the wrong package above 🙈 Just tested now also successfully with |
|
@christophfroehlich Any chance for a new release soon? |
|
I hoped that we could fix the failing tests on the buildfarm before, but nobody could help so far.. I'll trigger a release tonight. |
|
@bjsowa done |
3 participants
The
generate_parameter_modulemacro outputs the Python module toCMAKE_INSTALL_DIRduring the build phase. This results in build failures on the ROS buildfarm due to permission errors (example here)This PR modifies the macro to output the module to a temporary directory in
CMAKE_CURRENT_BINARY_DIRand install it toCMAKE_INSTALL_DIRduring the install phase.