Add RealTimeClock - Mcp7941xDriver.#98
Merged
stefanhaustein merged 4 commits intoPi4J:mainfrom Dec 6, 2025
Merged
Conversation
stefanhaustein
requested changes
Nov 29, 2025
src/main/java/com/pi4j/drivers/sensor/geospatial/mcp7941x/Mcp7941xDriver.java
Show resolved
Hide resolved
| i2c.writeRegister(YEAR, (byte) decToBcd(localDateTime.getYear() - 2000)); | ||
| } | ||
|
|
||
| public static int bcdToDec(int bcd) { |
Collaborator
There was a problem hiding this comment.
can you make this private for now, too?
| } | ||
|
|
||
| private static int decToBcd(int val) { | ||
| return ((val / 10) << 4) | (val % 10); |
Collaborator
There was a problem hiding this comment.
Please add a comment that this is limited to two digits (0..99) here and above
Collaborator
There was a problem hiding this comment.
This should make it generic (although it's not needed here)
if (val < 0) {
throw new IllegalArgumentException();
}
int result = 0;
while (val > 0) {
result = (result << 4) | (val % 10)
val /= 10
}
return result
Contributor
Author
There was a problem hiding this comment.
Half done.
The above logic breaks the code.
stefanhaustein
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.