Open
Conversation
low-sky
approved these changes
Jun 4, 2025
Collaborator
|
Looks good, just the one comment on my side to check |
Collaborator
|
@rchwn is this still relevant? I realise it's been sitting around for ages waiting for a reply to some comments I made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating the exposure-to-exposure and pointing-to-pointing DC flux offsets in MIRI data, I needed the ability to completely turn off the skymatch and LevelMatch steps, and to be able to turn them on individually. The current version of
lv3_step.pyruns skymatch by default. Suppose you've seti.e., you want skymatch to calculate the DC offsets between overlapping exposures, but do not want it to subtract them from the data. When skymatch is run by default, it adds the offsets to the headers, which the drizzle step adds to the data whether you like it or not. Without the ability to skip skymatch, there was no way to avoid that from happening.
Now in your
config.tomlfile, if you setskymatch will be skipped completely.