Perlguts: standardize on the _argument_stack#24362
Open
richardleach wants to merge 1 commit intoPerl:bleadfrom
Open
Perlguts: standardize on the _argument_stack#24362richardleach wants to merge 1 commit intoPerl:bleadfrom
richardleach wants to merge 1 commit intoPerl:bleadfrom
Conversation
Prior to this commit, the same stack was referred to as the "argument stack" in some places and the "value stack" in others. The former seems to have greater precedence and is the only variant used in other pod docs, so instances of the latter term have been reworded for consistency and reduced reader confusion.
Contributor
|
IMO value stack is a much better name than argument stack (even if the latter has more history), most obviously because it's not only used for argument but also for return values. |
Contributor
|
I think "value stack" is the better name, but most of perl (comments, other documentation) calls it the "argument stack". So if this does rename to "value stack" it should mention the "argument stack" name. |
Contributor
|
I added the "value stack" wording when I wrote about the various stacks in perlguts, largely because of Leon's observation there - it isn't just for arguments into a function, but also return values out of it. I'd prefer standardising on "value" rather than "argument" anyway, for that reason. |
Contributor
|
On Mon, Apr 13, 2026 at 07:22:18AM -0700, Paul Evans wrote:
I added the "value stack" wording when I wrote about the various stacks
in perlguts, largely because of Leon's observation there - it isn't just
for arguments into a function, but also return values out of it. I'd
prefer standardising on "value" rather than "argument" anyway, for that
reason.
Personally I prefer 'argument stack' because 'value stack' doesn't really
give a strong clue as to what you're referring to. Most of the perl stacks
contain values of one sort or another, while 'argument' is a strong hint,
even if it's not technically 100% correct.
And I would argue that it *is* technically correct: return values pushed
by functions and perl ops will be arguments to subsequent functions and
perl ops.
(all IMHO).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the same stack was referred to as the "argument stack" in some places and the "value stack" in others.
The former seems to have greater precedence and is the only variant used in other pod docs, so instances of the latter term have been reworded for consistency and reduced reader confusion.
Closes #21443