S_cleanup_regmatch_info_aux - don't Safefree(NULL)#24353
Open
richardleach wants to merge 1 commit intoPerl:bleadfrom
Open
S_cleanup_regmatch_info_aux - don't Safefree(NULL)#24353richardleach wants to merge 1 commit intoPerl:bleadfrom
richardleach wants to merge 1 commit intoPerl:bleadfrom
Conversation
One of the tasks of the `S_cleanup_regmatch_info_aux` destructor is to free any `aux->poscache` allocation. However, many regular expressions - such as a simple TRIE - don't cause an allocation to occur. This commit adds a check to ensure that an unnecessary function call isn't made in those instances.
richardleach
added
the
defer-next-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the tasks of the
S_cleanup_regmatch_info_auxdestructor is to free anyaux->poscacheallocation.However, many regular expressions - such as a simple TRIE - don't cause an allocation to occur. This commit adds a check to ensure that an unnecessary function call isn't made in those instances.