Skip to content

Configure, perlbug: Fall back to git user.email#24312

Open
danielzgtg wants to merge 1 commit intoPerl:bleadfrom
danielzgtg:feat/configureCfEmailDfltGitConfigUserEmail
Open

Configure, perlbug: Fall back to git user.email#24312
danielzgtg wants to merge 1 commit intoPerl:bleadfrom
danielzgtg:feat/configureCfEmailDfltGitConfigUserEmail

Conversation

@danielzgtg
Copy link
Copy Markdown
Contributor

Modern Linux installations, especially those at home, do not set domainname. I have "(none)". But most programmers use Git, so will have their email set there. Improving these defaults is convenient, as I have already mistyped my email in perlbug once.

Before

What is your e-mail address? [home@daniel-desktop3.(none)] 

After

What is your e-mail address? [[email protected]] 

  • This set of changes does not require a perldelta entry.

@jkeenan
Copy link
Copy Markdown
Contributor

jkeenan commented Mar 22, 2026

I configured on blead, then on this branch rebased on blead, to see what the differences in config.sh would be.

$ diff --ignore-matching-lines='Configuration time:' ../perl/config.sh ./config.sh
71,72c71,72
< cf_email='jkeenan@jk-bookworm.(none)'
< cf_time='Sun Mar 22 12:14:42 UTC 2026'
---
> cf_email='[email protected]'
> cf_time='Sun Mar 22 12:21:27 UTC 2026'
1005c1005
< perladmin='jkeenan@jk-bookworm.(none)'
---
> perladmin='[email protected]'

@Leont
Copy link
Copy Markdown
Contributor

Leont commented Mar 22, 2026

Had this been tested on a system without git? (I suspect all of our CI environments would have it).

@danielzgtg
Copy link
Copy Markdown
Contributor Author

I tested with both git invocations replaced with gitttt to simulate the command being missing, and got the previous behavior

Modern Linux installations, especially those at home, do not set
`domainname`. I have "(none)". But most programmers use Git, so will
have their email set there. Improving these defaults is convenient, as
I have already mistyped my email in `perlbug` once.
@danielzgtg danielzgtg force-pushed the feat/configureCfEmailDfltGitConfigUserEmail branch from 7376a33 to f38c89c Compare March 22, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants