Open
Conversation
PERL_EXT_RE_BUILD was listed twice. Remove the one where it was unconditionally set false; retaining the more flexible, hence accurate, one.
I did some more grepping of the source to look for symbols that we can assume are undefined for general usage, cpan and darkpan. An example is PERL_EXT_POSIX (seeing that in the source prompted this endeavor). That symbol should only be defined when compiling the POSIX module, so any symbols created only while it is #defined, won't be visible to the outside world. I looked for "/ \b PERL_ \w+ /x" and scanned through the list. The result are the symbols added here, which showed that 5 symbols this previously thought were visible everywhere actually aren't. So they are removed from the list.
Contributor
Some CPAN modules expect some of those to be available in some perl or another, but they provide their own definitions if they aren't visible. For example https://metacpan.org/release/PALI/DBD-MariaDB-1.24/source/dbdimp.h#L301 From looking at the perl history these were only visible for a short sequence of development perls though of the modules I looked at they had their backup definition from when their use was introduced, eg perl5-dbi/DBD-MariaDB@4b19d2e#diff-2f528efd07df9e85de883393dbeca1d5a26c512b958a6e917311dde6733c4dad I'd be inclined to make this defer-next-dev. |
khwilliamson
added
the
defer-next-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some more grepping of the source to look for symbols that we can assume are undefined for general usage, cpan and darkpan. An example is PERL_EXT_POSIX (seeing that in the source prompted this endeavour). That symbol should only be defined when compiling the POSIX module, so any symbols created only while it is #defined, won't be visible to the outside world.
I looked for "/ \b PERL_ \w+ /x" and scanned through the list. The result are the symbols added here, which showed that 5 symbols this previously thought were visible everywhere actually aren't. So they are removed from the list.