[DEBUG] do not use ULOG macros if BUILD_LIBULOG is not defined#10
Open
michael-elomar wants to merge 1 commit intoParrot-Developers:masterfrom
Open
[DEBUG] do not use ULOG macros if BUILD_LIBULOG is not defined#10michael-elomar wants to merge 1 commit intoParrot-Developers:masterfrom
michael-elomar wants to merge 1 commit intoParrot-Developers:masterfrom
Conversation
ymorgan
reviewed
Sep 22, 2025
src/pomp_watchdog.c
Outdated
| #if !TARGET_OS_IPHONE | ||
| res = pthread_setname_np("pomp_watchdog"); | ||
| if (res != 0) | ||
| #if defined(BUILD_LIBULOG) |
Contributor
There was a problem hiding this comment.
no need for the ifdef, POMP_LOG_ERRNO already use ulog if available
Author
There was a problem hiding this comment.
Ah yes, I just fixed it. Thanks for the review !!
michael-elomar
force-pushed
the
staging
branch
2 times, most recently
from
86a6a73 to
d826c34
Compare
michael-elomar
force-pushed
the
staging
branch
from
d826c34 to
00f5f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpomp must remain usable without libulog