Fix EntityDamageByEntityEvent returning wrong damager for ender pearls#442
Open
vLuckyyy wants to merge 1 commit intoPaperMC:ver/1.21.11from
Open
Fix EntityDamageByEntityEvent returning wrong damager for ender pearls#442vLuckyyy wants to merge 1 commit intoPaperMC:ver/1.21.11from
vLuckyyy wants to merge 1 commit intoPaperMC:ver/1.21.11from
Conversation
When a player uses an ender pearl to teleport, EntityDamageByEntityEvent#getDamager() was incorrectly returning the Player object instead of the CraftEnderPearl instance. This bug was in the Folia region threading code path. The attemptTeleport() method was passing 'player' to eventEntityDamager() instead of the ender pearl entity. Changes: - Added Entity enderPearl parameter to attemptTeleport() - Captured enderPearl in final variable for lambda use - Fixed damage source to use enderPearlFinal instead of player - Updated method call to pass 'this' (the ender pearl entity) Fixes PaperMC#438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438