Skip to content

[prone] Apply UnnecessarilyFullyQualified #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pankraz76 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[prone] Apply UnnecessarilyFullyQualified #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions gradle/error-prone.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ apply plugin: 'net.ltgt.errorprone'

dependencies {
errorprone('com.google.errorprone:error_prone_core:2.42.0')
// bug https://github.com/google/error-prone/issues/5293
// errorprone('com.google.errorprone:error_prone_core:2.43.0')
errorprone('tech.picnic.error-prone-support:error-prone-contrib:0.25.0')
}

Expand Down Expand Up @@ -31,6 +33,7 @@ tasks.withType(JavaCompile).configureEach {
)
error(
'AmbiguousJsonCreator',
'UnnecessarilyFullyQualified',
'AssertJNullnessAssertion',
'AutowiredConstructor',
'CanonicalAnnotationSyntax',
Expand Down Expand Up @@ -61,32 +64,33 @@ tasks.withType(JavaCompile).configureEach {
errorproneArgs.addAll(
'-XepPatchLocation:IN_PLACE',
'-XepPatchChecks:' +
'AmbiguousJsonCreator,' +
'ArrayEquals,' +
'AssertJNullnessAssertion,' +
'AutowiredConstructor,' +
'CanonicalAnnotationSyntax,' +
'CollectorMutability,' +
'ConstantNaming,' +
'DirectReturn,' +
'EmptyMethod,' +
'ExplicitArgumentEnumeration,' +
'ExplicitEnumOrdering,' +
'FormatStringConcatenation,' +
'IdentityConversion,' +
'ImmutablesSortedSetComparator,' +
'IsInstanceLambdaUsage,' +
'MockitoMockClassReference,' +
'MockitoStubbing,' +
'NestedOptionals,' +
'PrimitiveComparison,' +
'RedundantStringConversion,' +
'RedundantStringEscape,' +
'SelfAssignment,' +
'Slf4jLogStatement,' +
'StringJoin,' +
'StringJoining,' +
'TimeZoneUsage,'
'UnnecessarilyFullyQualified,'
// 'AmbiguousJsonCreator,' +
// 'ArrayEquals,' +
// 'AssertJNullnessAssertion,' +
// 'AutowiredConstructor,' +
// 'CanonicalAnnotationSyntax,' +
// 'CollectorMutability,' +
// 'ConstantNaming,' +
// 'DirectReturn,' +
// 'EmptyMethod,' +
// 'ExplicitArgumentEnumeration,' +
// 'ExplicitEnumOrdering,' +
// 'FormatStringConcatenation,' +
// 'IdentityConversion,' +
// 'ImmutablesSortedSetComparator,' +
// 'IsInstanceLambdaUsage,' +
// 'MockitoMockClassReference,' +
// 'MockitoStubbing,' +
// 'NestedOptionals,' +
// 'PrimitiveComparison,' +
// 'RedundantStringConversion,' +
// 'RedundantStringEscape,' +
// 'SelfAssignment,' +
// 'Slf4jLogStatement,' +
// 'StringJoin,' +
// 'StringJoining,' +
// 'TimeZoneUsage,'
)
}
}
Expand Down
4 changes: 2 additions & 2 deletions lib-extra/src/cdt/java/com/diffplug/spotless/extra/glue/cdt/EclipseCdtFormatterStepImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import java.util.Properties;
import java.util.stream.Collectors;
import java.util.stream.Stream;

import org.eclipse.cdt.core.ToolFactory;
import org.eclipse.cdt.core.formatter.CodeFormatter;
import org.eclipse.jface.text.Document;
import org.eclipse.jface.text.IDocument;
Expand All @@ -35,7 +35,7 @@ public EclipseCdtFormatterStepImpl(Properties settings) throws Exception {
Map<String, String> settingsMap = stream.collect(Collectors.toMap(
e -> String.valueOf(e.getKey()),
e -> String.valueOf(e.getValue())));
codeFormatter = org.eclipse.cdt.core.ToolFactory.createDefaultCodeFormatter(settingsMap);
Copy link
Owner Author

@Pankraz76 Pankraz76 Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its working with old version 42.

thanks to @delanym

codeFormatter = ToolFactory.createDefaultCodeFormatter(settingsMap);
}

/** Formatting C/C++ string */
Expand Down
Loading