[Cherry-Pick][Optimization]Fix tool parser (#7079)#7149
Open
luukunn wants to merge 2 commits intoPaddlePaddle:release/2.4from
Open
[Cherry-Pick][Optimization]Fix tool parser (#7079)#7149luukunn wants to merge 2 commits intoPaddlePaddle:release/2.4from
luukunn wants to merge 2 commits intoPaddlePaddle:release/2.4from
Conversation
* fix tool parser
|
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修复/优化 OpenAI 工具调用(tool call)解析逻辑,主要聚焦于 Ernie X1 的工具解析与流式解析路径,并补充了更大范围的单元测试覆盖。
Changes:
- 重构
ErnieX1ToolParser.extract_tool_calls:改为通过正则提取<tool_call>...</tool_call>并直接json.loads解析。 - 重构
ErnieX1ToolParser.extract_tool_calls_streaming:基于文本计数与partial_json_parser的流式增量解析逻辑。 - 大幅扩充
test_ernie_x1_tool_parser.py的用例覆盖;并在ernie_45_vl_thinking_tool_parser.py移除对空 chunk 的显式跳过逻辑。
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
fastdeploy/entrypoints/openai/tool_parsers/ernie_x1_tool_parser.py |
重构 Ernie X1 的非流式/流式工具解析实现,并调整日志与解析策略。 |
tests/entrypoints/openai/tool_parsers/test_ernie_x1_tool_parser.py |
补充大量针对 Ernie X1 工具解析的单测覆盖与分支覆盖。 |
fastdeploy/entrypoints/openai/tool_parsers/ernie_45_vl_thinking_tool_parser.py |
移除流式解析中对空白 chunk 的提前 return。 |
fastdeploy/entrypoints/openai/tool_parsers/ernie_x1_tool_parser.py
Outdated
Show resolved
Hide resolved
tests/entrypoints/openai/tool_parsers/test_ernie_x1_tool_parser.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #7149 +/- ##
==============================================
Coverage ? 56.46%
==============================================
Files ? 333
Lines ? 42615
Branches ? 6477
==============================================
Hits ? 24061
Misses ? 16683
Partials ? 1871
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.