Fix Molotov launch command after Fubo acquisition#829
Open
HerissonMan-TMP wants to merge 1 commit into
Open
Conversation
The previous adbLaunchCommand pointed to tv.molotov.android.main.MainActivity, which no longer exists since Molotov was acquired by Fubo and the main activity was renamed to tv.fubo.mobile.presentation.onboarding.dispatch.controller.DispatchActivity. Replaced "am start -n ..." with "monkey -p tv.molotov.app -c android.intent.category.LAUNCHER 1" for all Android-based device families (amazon-fire, chromecast, homatics, nvidia-shield, onn, xiaomi). This launches the app by package name and category, making it resilient to future activity renames within the Molotov/Fubo app. Tested on NVIDIA Shield TV Pro 2019 with Home Assistant androidtv integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Molotov app no longer launches on Android-based devices. The current
adbLaunchCommandusesam start -n tv.molotov.app/tv.molotov.android.main.MainActivity, which fails with:Error type 3
Error: Activity class {tv.molotov.app/tv.molotov.android.main.MainActivity} does not exist.
This is because Molotov was acquired by Fubo and the app was rebuilt on top of the Fubo codebase. The main activity was renamed to:
tv.fubo.mobile.presentation.onboarding.dispatch.controller.DispatchActivity
Fix
Replaced the explicit
am start -n ...command with:adb shell monkey -p tv.molotov.app -c android.intent.category.LAUNCHER 1
This launches the app by package name + LAUNCHER category, equivalent to clicking its icon in the Android launcher. It bypasses the activity-name issue entirely and should be resilient to future renames as Molotov/Fubo continues to merge their codebases.
Applied to all Android-based device families:
amazon-fire,chromecast,homatics,nvidia-shield,onn,xiaomi.apple-tvis unchanged since it uses a different mechanism.Testing
Tested on NVIDIA Shield TV Pro 2019 with the Home Assistant
androidtvintegration. App launches correctly from the firemote card. Verified viadumpsys window windowsthat the Fubo activity is what gets resolved when launching by package name.