fix: Handle null value for $plotGroupingType in writePlotGroup#3976
fix: Handle null value for $plotGroupingType in writePlotGroup#3976homersimpsons wants to merge 1 commit intoPHPOffice:masterfrom
null value for $plotGroupingType in writePlotGroup#3976Conversation
|
Note that I am not aware enough about the internals to create a concise enough unit test (without relying on an external file), but I would happily use some guidance. |
d9e4f00 to
2969578
Compare
|
Sometimes our tests do need to rely on an external file. Do you have an input file which demonstrates the problem when you load and then try to save it? If so, we can use that to construct a unit test. |
Yes I have such file in #3975: example_plot_grouping_type_null.xlsx |
|
Thank you for the sample file. You are correct that your fix eliminates the exception; however, the file that is produced is corrupt (error message when Excel opens it). So your change needs something more. I will take a look, but it may take several days before I can get to it. |
Okay, so it looks like google sheet has an issue then.
No worries, I found this bug while investigating another one so I'm not facing it. I put some details in #3975 about my analysis of the issue. |
This is:
Checklist:
Why this change is needed?
Fixes #3975