Feature/revert notification source facade changes#231
Merged
dbeuchler merged 4 commits intoPHOENIXCONTACT:release/5from Oct 10, 2025
Merged
Conversation
Member
1nf0rmagician
left a comment
1nf0rmagician
left a comment
There was a problem hiding this comment.
There is also a merge conflict, could you rebase your branch? 😬
dbeuchler
approved these changes
Oct 10, 2025
Member
Author
my first rebase; hope it is done correctly. |
dbeuchler
reviewed
Oct 10, 2025
Member
dbeuchler
left a comment
dbeuchler
left a comment
There was a problem hiding this comment.
There was something wrong during rebase, a lot of duplicated commits.. could you fix that?
dacky179
force-pushed
the
feature/RevertNotificationSourceFacadeChanges
branch
from
cfb93ae to
ee14616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert changes of the NotificationSourceFacade and ResourceManagement.
@dbeuchler found the real problem within the NotificationPublisher in CS.