feat: 024 map UI enhancements, fire details bottom sheet V2, and docs cleanup#85
Open
feat: 024 map UI enhancements, fire details bottom sheet V2, and docs cleanup#85
Conversation
…kflow - Create 3 agent skills: feature-scaffold, theme-and-style, testing-patterns - Add 15 lint rules to analysis_options.yaml, remove deprecated rule - Auto-fix 264 issues (single quotes, const, final locals) - Document Plan Mode + Skills workflow replacing .specify
…ity hardening Phase 1 of codebase audit fixes: - Remove dart:io imports from 6 production source files (lib/) - Replace SocketException with http.ClientException (web-safe) - Replace Platform with defaultTargetPlatform in lib/ code - Update matching test files (service tests, location tests) - Preserve dart:io Platform in widget/integration test guards (tests always run on VM, need actual hardware detection for Google Maps native plugin availability) - Redact 3 literal API keys in SECURITY_AUDIT_REPORT doc - Upgrade actions/cache@v3 to @v4 in CI workflow (3 places) - Change CI dummy API key prefix from AIzaSy to FAKE_KEY_FOR_CI Test results: 1961 passed, 34 skipped, 8 failed (pre-existing) Analyzer: No issues found
- Add header comments to map_screen_test.dart and complete_map_flow_test.dart explaining why dart:io Platform is intentionally required (actual hardware detection for native plugin availability) - Update copilot-instructions.md Platform Guards section with clear production vs test rules, examples of correct and incorrect patterns, and list of files with legitimate dart:io usage
Phase 2 of codebase audit - documentation cleanup: - Delete 6 root docs duplicated in history/deprecated/ - Archive redacted security audit to history/audits/ - Move 29 root docs to Divio subcategories (guides/, reference/, explanation/, runbooks/) - Move 4 project-root .md files into docs/ structure - Clean history/ root: delete 5 duplicate session files, move 1 to sessions/ - Rebuild docs/README.md with 62 verified links (0 broken) All file moves preserve git history via git mv. docs/ root now contains only README.md and DOCUMENTATION_STRATEGY.md.
Phase 3: Code cleanup - remove orphaned code from prior refactors. Deleted 6 dead lib/ files (FireLocationService interface+impl+mock, ActiveFiresService, ActiveFiresResponse, DataSourceChip). Deleted 5 dead test files and 2 root artifacts (test_ser.dart, verify_xcode_integration.sh). Cleaned 2 surviving test files (removed MockFireLocationService references). Regenerated mocks via build_runner. Verification: flutter analyze 0 issues, 1939 passed / 28 skipped / 8 failed (pre-existing, no regressions).
- Update docs/README.md navigation - Add security audit report (2025-10-29) - Add app overview reference doc - Add brand guidelines reference doc
|
Visit the preview URL for this PR (updated for commit 661f955):
(expires Thu, 26 Feb 2026 12:16:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 98d957c400f86d658fc9917a1fc9948e12d63376 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map UI enhancements branch (024) with 22 commits covering:
Features & UI
Documentation
Maintenance
Testing