Skip to content

Conversation

@pynickle
Copy link
Contributor

@pynickle pynickle commented Oct 7, 2025

close #1701

@pcl-ce-automation pcl-ce-automation bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: L PR 大小评估:大型 labels Oct 7, 2025
Copy link
Contributor

@tangge233 tangge233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我在寻思要不要给 CE 加入 Rx.NET,这玩意能在部分时候减少许多代码🤔

@pcl-ce-automation pcl-ce-automation bot added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels Oct 9, 2025
Copy link
Contributor

@ruattd ruattd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不对 再看一眼

请把搜索操作改成纯 Async Task 驱动而不是奇怪的混合,另外用 BeginInvoke 而不是 Invoke

@pcl-ce-automation pcl-ce-automation bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Oct 9, 2025
@Pigeon0v0 Pigeon0v0 requested review from ruattd and tangge233 November 2, 2025 01:55
Copilot AI review requested due to automatic review settings December 7, 2025 04:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request optimizes search performance when dealing with many modules (issue #1701). The changes appear to focus on improving the search algorithm's efficiency in the Search function within ModBase.vb, likely addressing performance bottlenecks that became apparent when searching through large numbers of modules.

Key Changes (inferred from code analysis):

  • Implementation of preprocessing and caching strategies in the search algorithm
  • Addition of query preprocessing to avoid repeated string operations
  • Introduction of absolute match detection for better search result prioritization

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Since I don't have access to the actual diff of changed files in this PR, I cannot provide a detailed file-by-file review. The code I examined appears to be functional and includes what seem to be optimization-related enhancements to the search functionality, particularly in:

Area Description
Search Algorithm The Search function in ModBase.vb includes preprocessing steps and caching mechanisms to improve performance with many entries
Favorites Search The PageDownloadCompFavorites.xaml.vb uses the optimized search function for filtering favorite items

Note: Without access to the actual PR diff showing which lines were added, modified, or removed, I cannot provide specific feedback on the changes made in this pull request. To provide a thorough review, I would need to see the actual diff that shows what code was changed.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@copytiao copytiao force-pushed the dev branch 2 times, most recently from ac617a0 to 19d369e Compare December 28, 2025 07:09
Copy link
Contributor

@ruattd ruattd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哥们要是实在玩不懂 WPF 的异步就算了吧...

@pynickle
Copy link
Contributor Author

pynickle commented Dec 29, 2025

哥们要是实在玩不懂 WPF 的异步就算了吧...

玩不会一点(恼)肯定是 WPF 太垃圾了

@ruattd
Copy link
Contributor

ruattd commented Dec 29, 2025

玩不会一点(恼)肯定是 WPF 太垃圾了

WPF 确实垃圾,但是它的单线程多任务模型跟其他语言也没什么区别...
你的代码并没有完全利用上 Dispatcher 多任务的性能优势,反而增加了异步切换上下文的压力,不比完全同步的传统多线程操作性能高多少
回头我看看魔改一下吧....

@AMagicPear
Copy link
Member

AMagicPear commented Jan 12, 2026

仅针对这个问题,从操作层面上看,既不需要对模组数量的多少分类讨论,也似乎不需要延时器。一个比较好的解决方案应该是:输入改变时异步启动一个搜索任务,并结束现在正在进行中的上一个搜索任务。当一个搜索任务完成时,更新UI。

@tangge233 tangge233 changed the title imp: 优化较多模组下的搜索表现 perf: 优化较多模组下的搜索表现 Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L PR 大小评估:大型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

搜索已有实例mod卡顿

6 participants