Conversation
We have already created an instance of jaxRsOpenApi, use that instead of creating another object. JIRA: LIGHTY-418 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the OpenApiLighty class to enhance efficiency and maintainability by ensuring that the JaxRsOpenApi instance is reused rather than being redundantly instantiated. This change aligns with best practices for resource management and reduces unnecessary object creation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the code to reuse an existing jaxRsOpenApi instance instead of creating a new one, which is a good improvement. I've added one suggestion to further improve the singleton handling within the same area of code for better clarity and consistency.
| public Set<Object> getSingletons() { | ||
| return Set.of(new JaxRsOpenApi(openApiService, basePathString), | ||
| new OpenApiBodyWriter(new JsonFactoryBuilder().build())); | ||
| return Set.of(jaxRsOpenApi, new OpenApiBodyWriter(new JsonFactoryBuilder().build())); |
There was a problem hiding this comment.
The getSingletons() method should return pre-existing singleton instances. However, a new OpenApiBodyWriter is created here on each call. For better clarity and to adhere to the singleton pattern, consider creating the OpenApiBodyWriter instance outside this method (e.g., as a class field initialized within initProcedure), similar to how jaxRsOpenApi is handled.
1 participant
We have already created an instance of jaxRsOpenApi, use that instead of creating another object.
JIRA: LIGHTY-418