[23.x] Sync dependencies with latest odlparent#2594
[23.x] Sync dependencies with latest odlparent#2594ihrasko merged 4 commits intoPANTHEONtech:23.xfrom
Conversation
Adopt: - odlparent-14.1.7 - infrautils-7.0.10 - yangtools-14.0.21 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 60e3abf)
https://checkstyle.org/releasenotes.html#Release_12.1.1 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 0345b3c)
https://docs.junit.org/5.14.1/release-notes/#release-notes-5.14.1 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit bba097b)
https://github.com/apache/maven-jar-plugin/releases/tag/maven-jar-plugin-3.5.0 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 9ed6eee)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a series of dependency and plugin version updates across the project's core modules. The primary goal is to synchronize the project with the latest stable releases of its upstream components, including Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies to their latest versions, including odlparent, infrautils, yangtools, and some Maven plugins. The version bumps are applied consistently across the relevant pom.xml files. I've added a few suggestions to use Maven properties for repeated version numbers to improve maintainability.
Note: Security Review has been skipped due to the limited scope of the PR.
| <groupId>org.opendaylight.yangtools</groupId> | ||
| <artifactId>yang-maven-plugin</artifactId> | ||
| <version>14.0.20</version> | ||
| <version>14.0.21</version> |
There was a problem hiding this comment.
To improve maintainability and avoid hardcoding the same version in multiple places, consider defining a property for the yangtools version in the <properties> section and using it here. For example, you could add <yangtools.version>14.0.21</yangtools.version>.
| <version>14.0.21</version> | |
| <version>${yangtools.version}</version> |
| <groupId>org.opendaylight.yangtools</groupId> | ||
| <artifactId>binding-codegen</artifactId> | ||
| <version>14.0.20</version> | ||
| <version>14.0.21</version> |
There was a problem hiding this comment.
Use the yangtools.version property here as well for consistency.
| <version>14.0.21</version> | |
| <version>${yangtools.version}</version> |
| <groupId>org.opendaylight.odlparent</groupId> | ||
| <artifactId>checkstyle</artifactId> | ||
| <version>14.1.6</version> | ||
| <version>14.1.7</version> |
There was a problem hiding this comment.
To improve maintainability and avoid hardcoding the same version in multiple places, consider defining a property for the odlparent version in the <properties> section and using it here and for the spotbugs dependency. For example, you could add <odlparent.version>14.1.7</odlparent.version>.
| <version>14.1.7</version> | |
| <version>${odlparent.version}</version> |
| <groupId>org.opendaylight.odlparent</groupId> | ||
| <artifactId>spotbugs</artifactId> | ||
| <version>14.1.6</version> | ||
| <version>14.1.7</version> |
There was a problem hiding this comment.
Use the odlparent.version property here as well for consistency.
| <version>14.1.7</version> | |
| <version>${odlparent.version}</version> |
Tobianas
changed the title
2 participants
No description provided.