Cross-chain Strategy #2715

shahthepro · 2025-12-11T10:38:06Z

Code Changes

Check readme: https://github.com/OriginProtocol/origin-dollar/blob/shah/cross-chain-strategy-cctpv2/contracts/contracts/strategies/crosschain/crosschain-strategy.md

codecov · 2025-12-12T11:28:20Z

Codecov Report

❌ Patch coverage is 88.88889% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.81%. Comparing base (c1b85d1) to head (4ebe400).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
...strategies/crosschain/CrossChainMasterStrategy.sol	84.33%	13 Missing ⚠️
...strategies/crosschain/CrossChainRemoteStrategy.sol	86.02%	12 Missing and 1 partial ⚠️
...s/strategies/crosschain/AbstractCCTPIntegrator.sol	90.47%	9 Missing and 1 partial ⚠️
...s/contracts/strategies/Generalized4626Strategy.sol	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2715      +/-   ##
==========================================
+ Coverage   39.40%   43.81%   +4.40%     
==========================================
  Files         126      133       +7     
  Lines        5789     6131     +342     
  Branches     1537     1636      +99     
==========================================
+ Hits         2281     2686     +405     
+ Misses       3506     3441      -65     
- Partials        2        4       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sparrowDom · 2025-12-15T11:52:03Z

contracts/contracts/mocks/crosschain/CrossChainRemoteStrategyMock.sol

+pragma solidity ^0.8.0;
+
+/**
+ * @title OUSD Yearn V3 Remote Strategy Mock - the Mainnet part


"- the Mainnet part" should probably be "- the L2 chain part"

contracts/contracts/mocks/crosschain/CrossChainRemoteStrategyMock.sol

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol

* fix deploy files * minor rename * add calls to Morpho Vault into a try catch * refactor hook wrapper * don't revert if withdraw from underlying fails * use checkBalance for deposit/withdrawal acknowledgment * update message in remote strategy * remove unneeded functions

sparrowDom

comments inline

contracts/contracts/strategies/crosschain/CrossChainRemoteStrategy.sol

sparrowDom

Idea how to change message finality checks

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol

sparrowDom

Latest batch of review comments

contracts/contracts/strategies/crosschain/CrossChainMasterStrategy.sol

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol

contracts/contracts/strategies/crosschain/CrossChainMasterStrategy.sol

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol

contracts/contracts/strategies/crosschain/CrossChainMasterStrategy.sol

contracts/contracts/strategies/crosschain/CrossChainRemoteStrategy.sol

* use Strategizable * Add comment --------- Co-authored-by: Shahul Hameed <[email protected]>

contracts/contracts/strategies/crosschain/CrossChainRemoteStrategy.sol

sparrowDom · 2026-01-09T16:33:27Z

contracts/contracts/strategies/crosschain/CrossChainRemoteStrategy.sol

+        uint256 balance = checkBalance(usdcToken);
+        bytes memory message = CrossChainStrategyHelper
+            .encodeBalanceCheckMessage(lastTransferNonce, balance, false);
+        _sendMessage(message);


I know we emit a more generic "MessageTransmitted" here. It might be useful to also emit a separate BalanceCheck event here.

sparrowDom and others added 5 commits December 5, 2025 14:54

some scaffolding

637fb40

add basic necessities for unit tests

7630f6d

checkpoint

6a97767

Fix compiling issues

9517fca

Add fork test scaffolding

41f1fd9

shahthepro added 5 commits December 13, 2025 00:30

Fix stuffs

7a109cc

Prettify and change salt

48d317e

Add auto-verification

c6a254a

Fix checkBalance

8f4e39e

Make CCTPHookWrapper more resilient

f7a9b97

sparrowDom reviewed Dec 15, 2025

View reviewed changes

contracts/contracts/mocks/crosschain/CrossChainRemoteStrategyMock.sol Outdated Show resolved Hide resolved

refactor message version and type checks

b3c1eb4

sparrowDom reviewed Dec 16, 2025

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Outdated Show resolved Hide resolved

sparrowDom reviewed Dec 16, 2025

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Show resolved Hide resolved

sparrowDom reviewed Dec 16, 2025

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Show resolved Hide resolved

sparrowDom reviewed Dec 16, 2025

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Show resolved Hide resolved

sparrowDom reviewed Dec 16, 2025

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Outdated Show resolved Hide resolved

sparrowDom and others added 11 commits December 16, 2025 16:50

add some comments

d3c4a39

add comment

792c890

fix compile errors

70166bc

Change addresses

1e700b1

Merge branch 'master' into shah/cross-chain-strategy-cctpv2

ada1546

Fix compilation issues

987dc0a

Fix deployment files a bit

b63bd5f

Fix Message relayer

bf1fbe2

Clean up master strategy

a0dd07b

Fix deployment file name

4071943

sparrowDom and others added 3 commits January 7, 2026 18:55

adjust some comments

b9b0035

have consistent event names

c4bc36d

fix: remove redundant check

9f7d423

sparrowDom reviewed Jan 7, 2026

View reviewed changes

shahthepro and others added 2 commits January 7, 2026 22:03

simplify stuff

ad9dc47

adjust comment

bd51e56

sparrowDom reviewed Jan 7, 2026

View reviewed changes

shahthepro and others added 4 commits January 8, 2026 14:52

fix: variable name

3729fa8

Add TokensBridged and MessageTransmitted events

800e21b

Add finality threshold checks

75e260f

add comment regarding fast transfers

a1482a0

sparrowDom reviewed Jan 8, 2026

View reviewed changes

Add analytics info

b674c75

sparrowDom reviewed Jan 9, 2026

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Outdated Show resolved Hide resolved

sparrowDom reviewed Jan 9, 2026

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Outdated Show resolved Hide resolved

sparrowDom reviewed Jan 9, 2026

View reviewed changes

contracts/contracts/strategies/crosschain/AbstractCCTPIntegrator.sol Outdated Show resolved Hide resolved

sparrowDom reviewed Jan 9, 2026

View reviewed changes

contracts/contracts/strategies/crosschain/CrossChainMasterStrategy.sol Show resolved Hide resolved

sparrowDom reviewed Jan 9, 2026

View reviewed changes

contracts/contracts/strategies/crosschain/CrossChainRemoteStrategy.sol Outdated Show resolved Hide resolved

shahthepro and others added 7 commits January 9, 2026 15:41

Change error message

d23548e

Set 1 USDC as min allowed value for deposits

d9b2a49

Change comment

eb66a55

Change comment

a7e0ae9

Update max transfer amount comment

6022c93

Set nonce(0) as processed during initialization

6a3846d

Use Strategizable for strategist functionality (#2740)

fafe7d4

* use Strategizable * Add comment --------- Co-authored-by: Shahul Hameed <[email protected]>

sparrowDom reviewed Jan 9, 2026

View reviewed changes

contracts/contracts/strategies/crosschain/CrossChainRemoteStrategy.sol Show resolved Hide resolved

sparrowDom and others added 3 commits January 9, 2026 18:05

set vault address to zero (#2742)

d80f754

remove unnecessary comments

7bbafc3

Add comment

7d7d2f9

sparrowDom reviewed Jan 9, 2026

View reviewed changes

Cross-chain Strategy #2715

Are you sure you want to change the base?

Cross-chain Strategy #2715

Conversation

shahthepro commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Changes

Uh oh!

codecov bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sparrowDom Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sparrowDom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sparrowDom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sparrowDom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sparrowDom Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shahthepro commented Dec 11, 2025 •

edited

Loading

codecov bot commented Dec 12, 2025 •

edited

Loading