Fix OrchardCore.SourceGenerators NuGet pack failure (Lombiq Technologies: NEST-608) #19043
Open
sarahelsaig wants to merge 2 commits intoOrchardCMS:mainfrom
Open
Fix OrchardCore.SourceGenerators NuGet pack failure (Lombiq Technologies: NEST-608) #19043sarahelsaig wants to merge 2 commits intoOrchardCMS:mainfrom
sarahelsaig wants to merge 2 commits intoOrchardCMS:mainfrom
Conversation
…tPath is missing the framework identifier so it has to be included in the path.
gvkries
reviewed
Mar 22, 2026
| <IsRoslynComponent>true</IsRoslynComponent> | ||
| <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> | ||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> |
Member
There was a problem hiding this comment.
I think this alone is not the correct fix, because it would place the assembly in the lib folder as a normal reference. See #19040 for a different approach.
Contributor
Author
There was a problem hiding this comment.
It places the assembly in both places:
Which is not harmful, and it means more consistent behavior and that this project won't have an irregular bin folder path. On the other hand, Copilot's "fix" looks very hackish and confusing. I really don't like this, even if it's 0B:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19038