Add new module for pruning old content items versions.#18983
Add new module for pruning old content items versions.#18983PUXVSE wants to merge 1 commit intoOrchardCMS:mainfrom
Conversation
|
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. If you like Orchard Core, please star our repo and join our community channels. |
|
@dotnet-policy-service agree company="PUXdesign" |
| var query = _session | ||
| .Query<ContentItem, ContentItemIndex>(x => | ||
| !x.Latest && | ||
| !x.Published && | ||
| (x.ModifiedUtc == null || x.ModifiedUtc < dateThreshold)); | ||
|
|
||
| var filterByType = settings.ContentTypes?.Length > 0; | ||
| if (filterByType) | ||
| { | ||
| query = query.Where(x => x.ContentType.IsIn(settings.ContentTypes)); | ||
| } | ||
|
|
||
| var candidates = await query.ListAsync(); | ||
|
|
||
| var versionsToKeep = Math.Max(0, settings.VersionsToKeep); | ||
|
|
||
| return ContentVersionPruningSelector.SelectForDeletion(candidates, versionsToKeep); |
There was a problem hiding this comment.
This ISession querying here and then filtering in ContentVersionPruningSelector.SelectForDeletion() is quite inefficient as it pulls all content items to memory for GroupBy and Skip.
However ISession doesn't provide API to do these operations in database query - following SQL command is needed (MSSQL version) and I haven't find a nice way to accomplish this (rather than writing raw SQL for each database provider):
SELECT
[ContentItemId],
[ContentItemVersionId]
FROM (
SELECT
[ContentItemId],
[ContentItemVersionId],
[Latest],
[Published],
[ContentType],
[ModifiedUtc],
ROW_NUMBER() OVER (
PARTITION BY [ContentItemId]
ORDER BY [ModifiedUtc] DESC
) AS [RowNum]
FROM [ContentItemIndex]
WHERE [Latest] != 1 AND [Published] != 1
) AS [Ranked]
WHERE [RowNum] > 1 -- skip N=1 newest rows per group
ORDER BY [ContentItemId], [ModifiedUtc] DESC
1 participant
Fixes #12669
Similar to AuditTrail trimming or Workflow trimming settings.