Dynamic translation for search form placeholder text (Lombiq Technologies: OCORE-255) by Piedone · Pull Request #18981 · OrchardCMS/OrchardCore

Piedone · 2026-03-11T00:47:25Z

No description provided.

hishamco · 2026-03-11T01:09:43Z

src/OrchardCore.Themes/TheBlogTheme/Views/Search-Form.liquid

 {% endif %}

-{% assign placeholder = Model.Placeholder | default: 'Enter your search term(s)' %}
+{% assign placeholder = Model.Placeholder | default: 'Enter your search term(s)' | t %}


Placeholder is dynamic data, right?

I'm not sure I understand what you mean. Model.Placeholder comes from the search settings and can be provided by the admin user.

This should use IDataLocalizer if I'm not wrong

Ah right, indeed. Fixed that.

hishamco · 2026-03-12T01:41:26Z

src/OrchardCore.Themes/TheBlogTheme/Views/Search-Form.liquid

 {% endif %}

-{% assign placeholder = Model.Placeholder | default: 'Enter your search term(s)' | t %}
+{% assign placeholder = Model.Placeholder | default: 'Enter your search term(s)' | d %}


Let me add a liquid filter for it

Isn't there one? I assumed there will be, and this actually turned out working indeed.

AFAIK, there's t only. Now I'm adding a data localization filter in a new PR

Now the question is, if this was entered by the admin, there should be some sort of context to make it translatable

I assumed there will be, and this actually turned out working indeed.

How do you localize the dynamic placeholder in PO?

@sebastienros, correct me if I'm wrong regarding my comment #18981 (comment)

…nslation

hishamco · 2026-03-12T22:07:25Z

src/OrchardCore.Themes/TheBlogTheme/Views/Search-Form.liquid

 {% endif %}

-{% assign placeholder = Model.Placeholder | default: 'Enter your search term(s)' %}
+{% assign placeholder = Model.Placeholder | default: "Enter your search term(s)" | d: "Search" %}


"Search" in this context is easy to add, but it needs a provider to capture all the localization strings :)

Added a provider too.

Wait, what? It's a static string, use t, not d, it's a fundamental misunderstanding otherwise (maybe from me).

Ya t is suited for "Enter your search term(s)" but for Model.Placeholder IMHO d is suited because it's dynamic, right?

If this is used as a trick and anything will return the same translation slot for this provider, then the context should be more specific. But instead I'd used the actual text, from the placeholder value. Or we are creating a provider for a single value

This diff here shows old code. The current one uses t for the default and d for the admin-configured placeholder: https://github.com/OrchardCMS/OrchardCore/pull/18981/changes#diff-6de49ec02dc75dceeeb8efc8b73b1f4db6c2e42a66cef2b5a1b3cb49ba9057ff.

But note that this won't properly work yet, unless you merge from #18988 first. That needs to be merged before this PR. And yes, for that to work, this does have a provider for a single value.

hishamco · 2026-03-13T01:19:37Z

@Piedone, I'm planning to introduce a new provider to help with the use case. The basic idea is to create a localization provider that allows the user to participate in adding localization strings

hishamco · 2026-03-13T10:38:14Z

FYI #18999

hishamco · 2026-03-16T02:18:45Z

src/OrchardCore.Modules/OrchardCore.Search/Services/SearchLocalizationDataProvider.cs

+        if (string.IsNullOrEmpty(searchSettings.Placeholder))
+        {
+            return Enumerable.Empty<DataLocalizedString>();
+        }


Suggested change

if (string.IsNullOrEmpty(searchSettings.Placeholder))

{

return Enumerable.Empty<DataLocalizedString>();

}

var placeholder = string.IsNullOrEmpty(searchSettings.Placeholder)

? "Enter your search term(s)"

: searchSettings.Placeholder

Why would we do this? If you didn't specify the placeholder in search settings, then the default will be used, which has a static PO translation.

I assume your other comments are related to this too. However, for the templates to be changed SearchController needs to be changed as well.

hishamco · 2026-03-16T02:19:00Z

src/OrchardCore.Modules/OrchardCore.Search/Services/SearchLocalizationDataProvider.cs

+
+        return new[]
+        {
+            new DataLocalizedString("Search", searchSettings.Placeholder, string.Empty),


Suggested change

new DataLocalizedString("Search", searchSettings.Placeholder, string.Empty),

new DataLocalizedString("Search", placeholder, string.Empty),

hishamco · 2026-03-16T02:19:59Z

src/OrchardCore.Modules/OrchardCore.Search/Views/Search-Form.cshtml

 }
 <form asp-action="Search" asp-controller="Search" asp-area="OrchardCore.Search" asp-route-index="@Model.Index" method="get">
    <div class="input-group mb-3 mt-5">
        <input name="Terms" type="text" value="@Model.Terms" class="form-control form-control-lg" placeholder="@placeholder" autofocus />


Suggested change

<input name="Terms" type="text" value="@Model.Terms" class="form-control form-control-lg" placeholder="@D[Model.Placeholder, "Search"].Value" autofocus />

hishamco · 2026-03-16T02:20:20Z

src/OrchardCore.Modules/OrchardCore.Search/Views/Search-Form.cshtml

+@{
+    var placeholder = string.IsNullOrWhiteSpace(Model.Placeholder)
+        ? T["Enter your search term(s)"].Value
+        : D[Model.Placeholder, "Search"].Value;
 }


Suggested change

@{

var placeholder = string.IsNullOrWhiteSpace(Model.Placeholder)

? T["Enter your search term(s)"].Value

: D[Model.Placeholder, "Search"].Value;

}

hishamco · 2026-03-16T02:21:28Z

src/OrchardCore.Themes/TheBlogTheme/Views/Search-Form.liquid

+{% assign placeholder = "Enter your search term(s)" | t %}
+{% else %}
+{% assign placeholder = Model.Placeholder | d: "Search" %}
+{% endif %}


Suggested change

{% assign placeholder = "Enter your search term(s)" | t %}

{% else %}

{% assign placeholder = Model.Placeholder | d: "Search" %}

{% endif %}

{% assign placeholder = Model.Placeholder | d: "Search" %}

Missing translation for search form placeholder text

a75061d

Piedone mentioned this pull request Mar 11, 2026

Small search fixes (Lombiq Technologies: OCORE-255) #18862

Merged

Piedone requested a review from hishamco March 11, 2026 00:47

hishamco reviewed Mar 11, 2026

View reviewed changes

Using data localizer

1be613a

hishamco reviewed Mar 12, 2026

View reviewed changes

Piedone added 2 commits March 12, 2026 22:17

Adding context to data localizer

87fa08d

Merge remote-tracking branch 'official/main' into issue/OCORE-255-tra…

99724c5

…nslation

Piedone added the don't merge label Mar 12, 2026

Piedone mentioned this pull request Mar 12, 2026

Add data localization liquid filter #18988

Merged

hishamco reviewed Mar 12, 2026

View reviewed changes

Adding LocalizationDataProvider for search

9d50cc5

Piedone changed the title ~~Missing translation for search form placeholder text (Lombiq Technologies: OCORE-255)~~ Dynamic translation for search form placeholder text (Lombiq Technologies: OCORE-255) Mar 13, 2026

Piedone removed the don't merge label Mar 13, 2026

Piedone added 2 commits March 13, 2026 02:02

Merge branch 'main' into issue/OCORE-255-translation

20a801d

Seal

da85c9e

hishamco mentioned this pull request Mar 14, 2026

Add SharedLocalizationDataProvider #18999

Open

Piedone requested a review from hishamco March 15, 2026 19:14

hishamco requested changes Mar 16, 2026

View reviewed changes

-        if (string.IsNullOrEmpty(searchSettings.Placeholder))
-        {
-            return Enumerable.Empty<DataLocalizedString>();
-        }
+        var placeholder = string.IsNullOrEmpty(searchSettings.Placeholder)
+            ? "Enter your search term(s)"
+            :  searchSettings.Placeholder

	new DataLocalizedString("Search", searchSettings.Placeholder, string.Empty),
	new DataLocalizedString("Search", placeholder, string.Empty),


	<input name="Terms" type="text" value="@Model.Terms" class="form-control form-control-lg" placeholder="@D[Model.Placeholder, "Search"].Value" autofocus />

Conversation

Piedone commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piedone Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hishamco commented Mar 13, 2026

Uh oh!

hishamco commented Mar 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piedone Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Piedone commented Mar 11, 2026 •

edited

Loading

Piedone Mar 12, 2026 •

edited

Loading

Piedone Mar 18, 2026 •

edited

Loading