Create Data Localization editor

[sebastienros]

No description provided.

[hishamco]

Believe it or not, I wanted to demo a dynamic localization for menus yesterday, but Im little bit sick

[hishamco]

At first glance, the editor was amazing!! But it needs a few UI tweaks. I will have an overall look at other files and fix the build.

Now I can vote for releasing v3.0.0 :)

[hishamco]

Just a few notes:

• Filter should be by Content Type, which will make the list short
• Use the technical name rather than the display name, because you can't guarantee that it will never change
• The Translations is confusing, coz there's content translations, and maybe static translations, let us name it Data Localization Translations or Dynamic Translations
• Statistics could be moved into a separate feature
• Some UI enhancements - could be deferred after this PR -

[sebastienros]

Filter should be by Content Type, which will make the list short

I thought about it but then you have the opposite effect that you may drown the other sections if there are many type

Use the technical name rather than the display name, because you can't guarantee that it will never change

The displayed text is the input if there is no translation, so it has to be the display name. Unless there is an API update that takes the "display name" as a fallback of D["technical", "display name in english"]

The Translations is confusing, coz there's content translations, and maybe static translations, let us name it Data Localization Translations or Dynamic Translations

Sure, change the menu and/or its location

Statistics could be moved into a separate feature

Not sure. Maybe not in the menu but from the translations page instead. It doesn't hurst, just a readonly page, no cost, and quite useful if you actually need to the data localization feature.

Some UI enhancements - could be deferred after this PR -

Yes this shouldn't block, but if there are obvious simple changes don't wait for me. Like the space between the buttons, ...

[hishamco]

Is there anything else to add here? I will review one more time and fix small UI issues. We need to merge this ASAP

[sebastienros]

@hishamco I pushed the fields localization. This should be it now.

I changed the way the context was built for fields so there is no collision between parts but still display them grouped. The context can have parts separated by ;. I didn't want to change the API, it's getting messy otherwise. Please give it a little test to ensure fields are correctly localized and displayed.

[hishamco]

Sure, I need to fix the unit tests too

[sebastienros]

I tested it and applied some changes.

[hishamco]

I will do a final review and test, then we are ready to merge this

[hishamco]

LGTM, let's merge this, so it should not take so long. After that, we can enhance it

The only thing I'm still thinking about is making the statistics a separate feature, which could be enabled by default. Also, we might add a permission for it

[sebastienros]

@hishamco I hope you didn't break it ;)

[hishamco]

No worry :) BTW I have a few enhancements that I might share in upcoming PRs

[hishamco]

After the module is almost complete, is there anything related to the PO Extractor that I haven't thought of? But could there be some places where the data localizer has been used with other localizers