Follow-up: Improvements for PR #476 (Added Nix development flake)#481
Open
HopHouse wants to merge 2 commits into
Open
Follow-up: Improvements for PR #476 (Added Nix development flake)#481HopHouse wants to merge 2 commits into
HopHouse wants to merge 2 commits into
Conversation
…he Proxmox environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please consider merging into t3rp/feature/nix-dev-flake or let me know if maintainers prefer a direct push.
Context
This PR contains improvements for @t3rp's PR #476.
Initially, I encountered some issues in using the correct Python version which is both:
I did not have Docker/Podman installed on my machine, so I created a Nix flake for my Proxmox environment.
Upon seeing @t3rp's Pull Request, I decided to continue its work and merge it with mine.
Solution
Merge @t3rp flake and mine to:
flake-utils.lib.eachDefaultSystemdevShellsandAppsseparatelyflake.lockto make it fully reproducibleTesting
All the derivation works well on my machine.
Linked PR