Skip to content

feat: remove axios and replace it with fetch - #21307

Closed
koji wants to merge 2 commits into
edgefrom
feat_remove-axios
Closed

feat: remove axios and replace it with fetch#21307
koji wants to merge 2 commits into
edgefrom
feat_remove-axios

Conversation

@koji

@koji koji commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Overview

Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources.

Test Plan and Hands on Testing

Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing.

Changelog

List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

  • Indicate the level of attention this PR needs.
  • Provide context to guide reviewers.
  • Discuss trade-offs, coupling, and side effects.
  • Look for the possibility, even if you think it's small, that your change may affect some other part of the system.
    • For instance, changing return tip behavior may also change the behavior of labware calibration.
  • How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions?
  • Especially in high risk PRs, explain how you know your testing is enough.

@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.08333% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.34%. Comparing base (201412c) to head (67ae2c7).
⚠️ Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
app-shell/src/usb.ts 1.51% 65 Missing ⚠️
app/src/redux/robot-api/http.ts 6.25% 15 Missing ⚠️
...tToRunProtocolSlideout/useCreateRunFromProtocol.ts 0.00% 10 Missing ⚠️
app/src/redux/shell/remote.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #21307      +/-   ##
==========================================
- Coverage   57.36%   57.34%   -0.02%     
==========================================
  Files        3993     3993              
  Lines      327582   327643      +61     
  Branches    46765    46764       -1     
==========================================
  Hits       187903   187903              
- Misses     139462   139523      +61     
  Partials      217      217              
Flag Coverage Δ
app 44.95% <2.08%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/App/OnDeviceDisplayApp.tsx 80.42% <ø> (+0.34%) ⬆️
...nisms/Desktop/SendProtocolToFlexSlideout/index.tsx 61.83% <ø> (ø)
...c/organisms/GripperWizardFlows/BeforeBeginning.tsx 92.92% <ø> (ø)
app/src/organisms/GripperWizardFlows/index.tsx 1.20% <ø> (ø)
...c/organisms/PipetteWizardFlows/BeforeBeginning.tsx 90.65% <ø> (ø)
.../src/resources/client_data/lpc/useClientDataLPC.ts 18.18% <ø> (ø)
...esources/client_data/lpc/useNotifyClientDataLPC.ts 11.11% <ø> (ø)
...rces/client_data/recovery/useClientDataRecovery.ts 18.18% <ø> (ø)
...lient_data/recovery/useNotifyClientDataRecovery.ts 11.11% <ø> (ø)
...s/labware_offsets/useNotifySearchLabwareOffsets.ts 12.50% <ø> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji changed the title Feat remove axios feat: remove axios and replace it with fetch May 1, 2026
@koji koji closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant