Conversation
rclarke0
requested review from
SyntaxColoring and
jerader
and removed request for
a team
April 9, 2026 21:47
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #21246 +/- ##
==========================================
- Coverage 57.20% 48.81% -8.39%
==========================================
Files 3987 3862 -125
Lines 326739 328324 +1585
Branches 46475 58714 +12239
==========================================
- Hits 186908 160286 -26622
- Misses 139612 167640 +28028
- Partials 219 398 +179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rclarke0
changed the title
jerader
reviewed
Apr 27, 2026
| const column = wellName.substring(1) | ||
| return `A${column} - H${column}` | ||
|
|
||
| switch (true) { |
Contributor
There was a problem hiding this comment.
why did you make this a switch statement? i find it a bit harder to read with it.
jerader
reviewed
Apr 27, 2026
| * @param wellName the target well for pickup tip | ||
| * @returns WellRange string of wells pipette will pickup tips from | ||
| */ | ||
| export function getWellRange( |
Contributor
There was a problem hiding this comment.
it would be a bit helpful to add some unit tests for each of these well ranges, if you have time
jerader
approved these changes
Apr 27, 2026
jerader
left a comment
jerader
left a comment
Contributor
There was a problem hiding this comment.
nice! just left a few questions. would be great to add a bit of unit test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Correctly display tips being picked up for all nozzle configurations
Test Plan and Hands on Testing
Changelog
Review requests
none
Risk assessment
closes AUTH-2223