fix: m_opt_backup_value not being initialized in CUICheckButton#2049
Merged
Xottab-DUTY merged 2 commits intoOpenXRay:devfrom Feb 11, 2026
Merged
fix: m_opt_backup_value not being initialized in CUICheckButton#2049Xottab-DUTY merged 2 commits intoOpenXRay:devfrom
m_opt_backup_value not being initialized in CUICheckButton#2049Xottab-DUTY merged 2 commits intoOpenXRay:devfrom
Conversation
This can lead to an uninitialized read when changing stuff in the options menu.
…ue directly in the class
Xottab-DUTY
approved these changes
Feb 11, 2026
Member
Xottab-DUTY
left a comment
There was a problem hiding this comment.
I've moved the initialization to the class definition as it's recommended and better practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can lead to an uninitialized read when changing stuff in the options menu.
UBSAN report: