Skip to content

Fix Rubocop lint#82

Merged
nmburgan merged 3 commits intoOpenVoxProject:mainfrom
Sharpie:fix-rubocop-lint
Apr 5, 2026
Merged

Fix Rubocop lint#82
nmburgan merged 3 commits intoOpenVoxProject:mainfrom
Sharpie:fix-rubocop-lint

Conversation

@Sharpie
Copy link
Copy Markdown
Contributor

@Sharpie Sharpie commented Apr 5, 2026

Short description

This changeset, hopefully, fixes the Rubocop link checks that have been causing the automated test Pipelines to fail.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document and added a Signed-off-by annotation to each of my commits
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Sharpie added 3 commits April 5, 2026 10:50
@Sharpie
Exclude extensions from Style/OneClassPerFile
ba798db 
This commit excludes files that modify classes from other Libraries from
the Style/OneClassPerFile Rubocop check as the use of multiple class
entries is intentional.

Signed-off-by: Charlie Sharpsteen <[email protected]>
@Sharpie
Lint: remove redundant map(&:to_s) before join
4e9267e 
This commit updates `rules.rb` to satisfy Rubocop Style/MapJoin by
removing explicit stringification before calling `.join`. The call
to `.map(&:to_s)` is redundant as the documented behavior of
`Array#join` is:

> - Uses `element.to_s` if element is not a `kind_of?(Array)`
> https://docs.ruby-lang.org/en/3.2/Array.html#method-i-join

Signed-off-by: Charlie Sharpsteen <[email protected]>
@Sharpie
Lint: Use to_h { ... } instead of each_with_object
ab6d8e9 
This commit updates the `hashable` extension to satisfy the
Rubocop Style/ReduceToHash check.

Signed-off-by: Charlie Sharpsteen <[email protected]>
@Sharpie Sharpie mentioned this pull request Apr 5, 2026
Merged
7 tasks
@nmburgan nmburgan merged commit 40aa1bd into OpenVoxProject:main Apr 5, 2026
6 checks passed
@Sharpie Sharpie deleted the fix-rubocop-lint branch April 5, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmburgan nmburgan nmburgan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sharpie @nmburgan